fix: remove unused runtime attr from defaultPlugin to fix nixpkgs compat #41
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
jiriks74/nvim.nix!41
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/remove-runtime-attr"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
Building the NixOS configuration fails with:
Root Cause
nixpkgs PR NixOS/nixpkgs#488793 (merged 2026-03-11) introduced
evalModules-based typechecking for Neovim plugin definitions. The newmodule.nixdefines a strictpluginWithConfigTypesubmodule that only accepts three options:plugin,config, andoptional.Our
nix/mkNeovim.nixhad adefaultPluginattrset with an extraruntime = {};attribute. Before PR #488793, extra attributes were silently ignored during plugin normalization. Now they cause a type error becauseevalModulesrejects unknown options.The
runtimeattribute was:{}(empty attrset)Fix
Remove
runtime = {};from thedefaultPlugindefinition innix/mkNeovim.nix. This is safe because the attribute was never used.runtimeattr from defaultPluginThe `runtime = {}` attribute in defaultPlugin was never part of the nixpkgs Neovim plugin schema. It was silently ignored until nixpkgs PR #488793 introduced `evalModules` typechecking for Neovim plugin definitions, which now rejects unknown attributes. The valid plugin options are: `plugin`, `config`, and `optional`. The `runtime` attribute was always set to `{}` (empty) and never consumed by any code, so removing it is safe and fixes the build error: The option `plugins."[definition 1-entry 1]".runtime' does not exist.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.